On 10/27/16 05:47, Rob Herring wrote: > On Tue, Oct 25, 2016 at 3:58 PM, <frowand.list@xxxxxxxxx> wrote: >> From: Frank Rowand <frank.rowand@xxxxxxxxxxx> > > I prefer to leave the prefixes and this is getting into pointless churn. > >> >> Signed-off-by: Frank Rowand <frank.rowand@xxxxxxxxxxx> >> --- >> drivers/of/resolver.c | 10 +++++----- >> 1 file changed, 5 insertions(+), 5 deletions(-) > If I was just submitting this as a single patch, I would agree. But since I am making so many other changes, I think it makes sense to do this as part of this series. It is broken apart as a separate patch to be easy to review and not pollute any of the other patches in the series. The prefixes add no value for a local function, but they do add noise when reading code. The changes are local to this file and do not impact anything else. Looking at the single patch, it does seem like churn. But looking at the entire file before the set of changes and after the set of changes, I find the file much easier to read afterwards. Each individual patch may make a small contribution to the end result, but the combination of all of them is significant. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
