On Wed, Oct 26, 2016 at 12:25:51PM +0100, Mark Rutland wrote: > > +Required properties: > > + > > +- compatible: should specify the actual hardware chip followed by the > > + generic interface name "tcg,tpm_tis-spi"; > > Please use '-' in comaptible strings rather than '_'. Erk, there is also a typo spi vs mmio. Note that the SPI patches were already Ack'd by DT so there is now precedent: Documentation/devicetree/bindings/security/tpm/tpm_tis_spi.txt: "tcg,tpm_tis-spi" Do you still want to change? Should we change spi too? > Please also describe chip strings, even if those aren't use by the > driver, e.g. Sure, I can give one or two, but the list will not be exhaustive, there are many different TPM chips that adhere to this standard. Thanks, Jason -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
