On Thu, Dec 05, 2013 at 04:43:37PM +0100, Denis Carikli wrote: > pwmr has to be set to get the imxfb backlight work, > though pwmr was only configurable trough the platform data. > > Cc: Rob Herring <rob.herring@xxxxxxxxxxx> > Cc: Pawel Moll <pawel.moll@xxxxxxx> > Cc: Mark Rutland <mark.rutland@xxxxxxx> > Cc: Stephen Warren <swarren@xxxxxxxxxxxxx> > Cc: Ian Campbell <ijc+devicetree@xxxxxxxxxxxxxx> > Cc: devicetree@xxxxxxxxxxxxxxx > Cc: Jean-Christophe Plagniol-Villard <plagnioj@xxxxxxxxxxxx> > Cc: Tomi Valkeinen <tomi.valkeinen@xxxxxx> > Cc: linux-fbdev@xxxxxxxxxxxxxxx > Cc: Sascha Hauer <kernel@xxxxxxxxxxxxxx> > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Cc: Eric Bénard <eric@xxxxxxxxxx> > Signed-off-by: Denis Carikli <denis@xxxxxxxxxx> > Acked-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@xxxxxxxxxxxx> > Acked-by: Grant Likely <grant.likely@xxxxxxxxxx> > --- > .../devicetree/bindings/video/fsl,imx-fb.txt | 3 +++ > drivers/video/imxfb.c | 2 ++ > 2 files changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/video/fsl,imx-fb.txt b/Documentation/devicetree/bindings/video/fsl,imx-fb.txt > index 46da08d..ac457ae 100644 > --- a/Documentation/devicetree/bindings/video/fsl,imx-fb.txt > +++ b/Documentation/devicetree/bindings/video/fsl,imx-fb.txt > @@ -17,6 +17,9 @@ Required nodes: > Optional properties: > - fsl,dmacr: DMA Control Register value. This is optional. By default, the > register is not modified as recommended by the datasheet. > +- fsl,pwmr: LCDC PWM Contrast Control Register value. That property is > + optional, but defining it is necessary to get the backlight working. If that > + property is ommited, the register is zeroed. Why isn't this implemented as a backlight driver? Static devicetree provided values is very limiting. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
