On Tue, 2016-10-25 at 13:58 -0700, frowand.list@xxxxxxxxx wrote: > From: Frank Rowand <frank.rowand@xxxxxxxxxxx> > > Remove comments that state the obvious, to reduce clutter Some of these removals might be overly aggressive. > diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c [] > @@ -125,7 +114,6 @@ static int __of_adjust_phandle_ref(struct device_node *node, > int offset, propcurlen; > int err = 0; > > - /* make a copy */ > propval = kmalloc(rprop->length, GFP_KERNEL); > if (!propval) { > pr_err("%s: Could not copy value of '%s'\n",ld This kmalloc/memcpy could use kmemdup instead. It doesn't really need the pr_err either as kmalloc and/or kmemdup get a generic OOM message. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html