On Tue, Oct 25, 2016 at 12:43 PM, Sekhar Nori <nsekhar@xxxxxx> wrote: > On Monday 24 October 2016 10:16 PM, ahaslam@xxxxxxxxxxxx wrote: >> From: Axel Haslam <ahaslam@xxxxxxxxxxxx> >> >> Currently, the da8xx ohci driver uses a set of gpios and callbacks in >> board files to handle vbus and overcurrent irqs form the power supply. >> However, this does not play nice when moving to a DT based boot were >> we wont have board files. >> >> Instead of requesting and handling the gpio, use the regulator framework >> to take care of enabling and disabling vbus power. This has the benefit >> that we dont need to pass any more platform data to the driver: >> >> These will be handled by the regulator framework: >> set_power -> regulator_enable/regulator_disable >> get_power -> regulator_is_enabled >> get_oci -> regulator_get_mode >> ocic_notify -> regulator notification >> >> We can keep the default potpgt and use the regulator start delay instead: >> potpgt -> regulator startup delay time >> >> The hawk board does not have a GPIO/OVERCURRENT gpio to control vbus, >> (they should not have been decleared/reserved) so, just remove those >> definitions from the hwk board file. >> >> Signed-off-by: Axel Haslam <ahaslam@xxxxxxxxxxxx> >> --- >> arch/arm/mach-davinci/board-da830-evm.c | 97 ++++++++---------------- >> arch/arm/mach-davinci/board-omapl138-hawk.c | 96 +----------------------- >> arch/arm/mach-davinci/include/mach/da8xx.h | 2 +- >> arch/arm/mach-davinci/usb-da8xx.c | 3 +- >> drivers/usb/host/ohci-da8xx.c | 111 ++++++++++++++++++---------- >> include/linux/platform_data/usb-davinci.h | 19 ----- >> 6 files changed, 105 insertions(+), 223 deletions(-) > > Can you separate out the driver enhancement from the platform > (mach-davinci) changes? They need to go through different trees. > Ok, i will do that, (it might require intermediate code to have the driver working on each patch) > Thanks, > Sekhar > > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
