On Monday 24 October 2016 10:16 PM, ahaslam@xxxxxxxxxxxx wrote: > From: Axel Haslam <ahaslam@xxxxxxxxxxxx> > > The phy framework requests an optional "phy" regulator. If it does > not find one, it returns -EPROBE_DEFER. In the case of non-DT based boot > for the omap138-lcdk board, this would prevent the usb11 phy to probe > correctly and ohci would not enumerate. > > By calling "regulator_has_full_constraints", An error would be returned nit: prefer regulator_has_full_constraints() > instead of DEFER for the "optional" regulator, and the probe of > the phy driver can continue normally without a regulator. > > Signed-off-by: Axel Haslam <ahaslam@xxxxxxxxxxxx> Looks good to me. Just drop the "hawk: from subject line since you also touch da830 evm. I am not sure what "ohci plat boot" means. How about the following: "ARM: davinci: da8xx: fix OHCI PHY probe for non-DT boot" Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
