On Mon, Oct 24, 2016 at 7:53 PM, Mark Brown <broonie@xxxxxxxxxx> wrote: > On Mon, Oct 24, 2016 at 06:46:26PM +0200, ahaslam@xxxxxxxxxxxx wrote: > >> + if (ret) { >> + pr_err("Failed to request irq: %d\n", ret); > > dev_err() > >> +++ b/include/linux/regulator/consumer.h >> @@ -74,6 +74,10 @@ >> * the most noisy and may not be able to handle fast load >> * switching. >> * >> + * OVERCURRENT Regulator has detected an overcurrent condition, and >> + * may be limiting the supply output. >> + * >> + * >> * NOTE: Most regulators will only support a subset of these modes. Some >> * will only just support NORMAL. >> * >> @@ -84,6 +88,7 @@ >> #define REGULATOR_MODE_NORMAL 0x2 >> #define REGULATOR_MODE_IDLE 0x4 >> #define REGULATOR_MODE_STANDBY 0x8 >> +#define REGULATOR_MODE_OVERCURRENT 0x10 > > This is adding a new core feature with a new mode and should have been > split out of the driver specific change with a spearate changelog. Why Ok, will do. > does it make sense to report this as a mode, we don't report other error > conditions as modes but instead use REGULATOR_STATUS_ with the > get_status() operation? I used mode, because when the regulator toggles the overcurrent line, it means that it has entered a current limited mode, at least the regulator im looking at. ill change to STATUS Regards Axel -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html