On Fri 21 Oct 04:11 PDT 2016, Jeremy McNicoll wrote:
> From: Jeremy McNicoll <jmcnicol@xxxxxxxxxx>
>
> Initial device tree support for Qualcomm MSM8992 SoC and
> LG Bullhead / Google Nexus 5X support.
>
Looks reasonable, just two small nits below.
> Signed-off-by: Jeremy McNicoll <jeremymc@xxxxxxxxxx>
> ---
> arch/arm64/boot/dts/qcom/Makefile | 4 +-
> .../boot/dts/qcom/msm8992-bullhead-rev-101.dts | 42 ++++
> arch/arm64/boot/dts/qcom/msm8992-pins.dtsi | 38 ++++
> arch/arm64/boot/dts/qcom/msm8992.dtsi | 214 +++++++++++++++++++++
> 4 files changed, 296 insertions(+), 2 deletions(-)
> create mode 100644 arch/arm64/boot/dts/qcom/msm8992-bullhead-rev-101.dts
> create mode 100644 arch/arm64/boot/dts/qcom/msm8992-pins.dtsi
> create mode 100644 arch/arm64/boot/dts/qcom/msm8992.dtsi
>
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index 5dd05de..abb366e 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -1,6 +1,6 @@
> dtb-$(CONFIG_ARCH_QCOM) += apq8016-sbc.dtb msm8916-mtp.dtb
> -dtb-$(CONFIG_ARCH_QCOM) += msm8996-mtp.dtb
> -dtb-$(CONFIG_ARCH_QCOM) += apq8096-db820c.dtb
> +dtb-$(CONFIG_ARCH_QCOM) += msm8996-mtp.dtb apq8096-db820c.dtb
Don't change these, just add yours.
[..]
> diff --git a/arch/arm64/boot/dts/qcom/msm8992.dtsi b/arch/arm64/boot/dts/qcom/msm8992.dtsi
[..]
> +
> + msmgpio: pinctrl@fd510000 {
> + compatible = "qcom,msm8994-pinctrl", "qcom,msm8974-pinctrl";
This device is not compatible with the msm8974 TLMM, so please drop the
second compatible.
> + reg = <0xfd510000 0x4000>;
> + interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + };
> +
Regards,
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
