On Thu 20 Oct 11:56 PDT 2016, Sarangdhar Joshi wrote: > Add SMP2P and APCS DT nodes required for Qualcomm ADSP > Peripheral Image Loader. > Nice, two (very) small nits below. But other than that Acked-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> Regards, Bjorn > Signed-off-by: Sarangdhar Joshi <spjoshi@xxxxxxxxxxxxxx> > --- > arch/arm64/boot/dts/qcom/msm8996.dtsi | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi > index 0a810f5..3edb56b 100644 > --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi > @@ -169,6 +169,31 @@ > method = "smc"; > }; > > + smp2p-adsp { Sorry for bikeshedding, but on msm8916 I named these {subsystem}-smp2p, so I would prefer this was naemd adsp-smp2p... > + compatible = "qcom,smp2p"; > + qcom,smem = <443>, <429>; > + > + interrupt-parent = <&intc>; I believe this node inherit intc as interrupt-parent from the root already, is there are reason why you need to specify it. > + interrupts = <0 158 IRQ_TYPE_EDGE_RISING>; > + > + qcom,ipc = <&apcs 16 10>; > + > + qcom,local-pid = <0>; > + qcom,remote-pid = <2>; > + > + adsp_smp2p_out: master-kernel { > + qcom,entry-name = "master-kernel"; > + #qcom,state-cells = <1>; > + }; > + > + adsp_smp2p_in: slave-kernel { > + qcom,entry-name = "slave-kernel"; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + }; > + > smem { > compatible = "qcom,smem"; > > @@ -205,6 +230,11 @@ > interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>; > }; > > + apcs: syscon@9820000 { > + compatible = "syscon"; > + reg = <0x9820000 0x1000>; > + }; > + > gcc: clock-controller@300000 { > compatible = "qcom,gcc-msm8996"; > #clock-cells = <1>; > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html