在 2016/10/19 10:45, Rob Herring 写道: > On Tue, Oct 18, 2016 at 9:38 PM, Jiancheng Xue > <xuejiancheng@xxxxxxxxxxxxx> wrote: >> >> >> 在 2016/10/18 23:58, Rob Herring 写道: >>> On Mon, Oct 17, 2016 at 08:07:04PM +0800, Pan Wen wrote: >>>> Add CRG driver for Hi3516CV300 SoC. CRG(Clock and Reset >>>> Generator) module generates clock and reset signals used >>>> by other module blocks on SoC. >>>> >>>> Signed-off-by: Pan Wen <wenpan@xxxxxxxxxxxxx> >>>> --- >>>> .../devicetree/bindings/clock/hisi-crg.txt | 50 ++++ >>>> drivers/clk/hisilicon/Kconfig | 8 + >>>> drivers/clk/hisilicon/Makefile | 1 + >>>> drivers/clk/hisilicon/crg-hi3516cv300.c | 330 +++++++++++++++++++++ >>>> drivers/clk/hisilicon/crg.h | 34 +++ >>>> include/dt-bindings/clock/hi3516cv300-clock.h | 48 +++ >>>> 6 files changed, 471 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/clock/hisi-crg.txt >>>> create mode 100644 drivers/clk/hisilicon/crg-hi3516cv300.c >>>> create mode 100644 drivers/clk/hisilicon/crg.h >>>> create mode 100644 include/dt-bindings/clock/hi3516cv300-clock.h >>>> >>>> diff --git a/Documentation/devicetree/bindings/clock/hisi-crg.txt b/Documentation/devicetree/bindings/clock/hisi-crg.txt >>>> new file mode 100644 >>>> index 0000000..cc60b3d >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/clock/hisi-crg.txt >>>> @@ -0,0 +1,50 @@ >>>> +* HiSilicon Clock and Reset Generator(CRG) >>> >>> Seems kind of generic given there's already various HiSi clock bindings >>> documented. >>> >>>> + >>>> +The CRG module provides clock and reset signals to various >>>> +modules within the SoC. >>>> + >>>> +This binding uses the following bindings: >>>> + Documentation/devicetree/bindings/clock/clock-bindings.txt >>>> + Documentation/devicetree/bindings/reset/reset.txt >>>> + >>>> +Required Properties: >>>> + >>>> +- compatible: should be one of the following. >>>> + - "hisilicon,hi3516cv300-crg" >>>> + - "hisilicon,hi3516cv300-sysctrl" >>>> + - "hisilicon,hi3519-crg" >>> >>> There is already a binding for this. Please merge them. >>> >> Hi Rob, >> >> Pan Wen and I work together. There's really a same file included in the patch >> https://lkml.org/lkml/2016/9/18/42 ([PATCH v2] clk: hisilicon: add CRG driver for Hi3798CV200 SoC). >> But that patch has not been acked. This binding file will be merged if that >> patch is accepted first. Could you give me more comments on that patch or >> help me to ack it? Thank you very much. > > If I haven't commented, then likely it was not sent to the DT list. Hi, I'm pretty sure that the patch was sent to the DT list devicetree@xxxxxxxxxxxxxxx. You had asked a question about "hi3798cv200-sysctrl" and I replied (https://lkml.org/lkml/2016/10/10/517). I'm waiting for your new comments. If there's some misunderstatnding, please let me know. Thanks, Jiancheng > > Rob > > . > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
