Hi, On Fri, Oct 14, 2016 at 11:06:14AM +0800, xiaogang@xxxxxxxxxxxxxx wrote: > 在 2016-10-14 10:41，Andy Yan 写道： > > On 2016年10月14日 10:02, Xiaogang Cui wrote: > > > This is a initial version so it's very similar with syscon > > > reboot mode driver. We will add more functionalities in the > > > further after dependency is ready. > > > > > > Signed-off-by: Xiaogang Cui <xiaogang@xxxxxxxxxxxxxx> > > > --- > > > > As your commit messages said, "it's very similar with syscon > > reboot mode driver", so maybe we can try to reuse the syscon > > reboot mode driver, and extend your new function on it. > > Since it will heavily depend on Qualcomm qpnp and download mode > driver. I prefer to add a new driver for this. So use syscon driver until then. In its current state is more or less a copy of syscon driver with s/syscon/qcom/g. I will not queue that. Just add a more specific compatible value in addition to the syscon one: compatible = "qcom,reboot-mode", "syscon-reboot-mode"; Then syscon driver is used and if something more complex is required later we can easily switch to it. -- Sebastian
Attachment:
signature.asc
Description: PGP signature
