On 10/14/2016 01:58 PM, Lars-Peter Clausen wrote:
> On 10/11/2016 03:57 PM, Tomas Novotny wrote:
>
> Hi,
>
> Looks mostly good. One small thing that should be addressed.
>
>> diff --git a/include/linux/iio/dac/mcp4725.h b/include/linux/iio/dac/mcp4725.h
>> index 91530e6..7c062e8 100644
>> --- a/include/linux/iio/dac/mcp4725.h
>> +++ b/include/linux/iio/dac/mcp4725.h
>> @@ -10,7 +10,6 @@
>> #define IIO_DAC_MCP4725_H_
>>
>> struct mcp4725_platform_data {
>> - u16 vref_mv;
>> };
>
> Might as well remove the whole struct and file and drop the if (!pdata)
> check in the driver probe function. Having to declare a empty platform_data
> for the driver to work is not that sensible.
Ok, I see, new fields are added in the next commit. So ignore this.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
