On Tuesday, October 11, 2016 7:41:22 PM CEST Rob Herring wrote: > On Sat, Oct 1, 2016 at 9:38 PM, Jeremy McNicoll <jmcnicol@xxxxxxxxxx> wrote: > > These non standard DT entries need to be cast aside as to not > > pollute the main device tree bindings. Without these essential > > DT items the bootloader/LK will not pass control over to the kernel > > and thus never boot. > > I discussed this with Stephen recently. I'm okay with leaving these on > boards that have no chance of getting updated bootloaders to use the > compatible string instead. Having to use dtbTool is far worse than a > couple of extra properties IMO. I reserve the right to complain if new > stuff continues to use these though. > > > Signed-off-by: Jeremy McNicoll <jeremymc@xxxxxxxxxx> > > --- > > .../arm64/boot/dts/qcom/msm8994-angler-rev-101.dts | 1 - > > arch/arm64/boot/dts/qcom/msm8994.dtsi | 3 +-- > > .../boot/dts/qcom/nexus6p_bootloader_bits.dtsi | 24 ++++++++++++++++++++++ > > Just put this into the board file rather than yet another include. The suggestion that I had was to have two .dts files: the normal one without these properties, and another .dts file including the first but adding these three for compatibility with the legacy bootloaders. That way we could have a 'clean' .dtb file once the bootloaders get fixed, and can name the other one appropriately to discourage copying the method for new machines. Having the bootloader files included from the main .dts files would serve no purpose. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
