Hi Sergio, On Wed, 5 Oct 2016 20:46:57 -0300 Sergio Prado <sergio.prado@xxxxxxxxxxxxxx> wrote: > Allows configuring Samsung's s3c2410 memory controller using a > devicetree. > > Signed-off-by: Sergio Prado <sergio.prado@xxxxxxxxxxxxxx> > --- > drivers/mtd/nand/s3c2410.c | 171 ++++++++++++++++++++++--- > include/linux/platform_data/mtd-nand-s3c2410.h | 1 + > 2 files changed, 156 insertions(+), 16 deletions(-) > > diff --git a/drivers/mtd/nand/s3c2410.c b/drivers/mtd/nand/s3c2410.c > index 174ac9dc4265..352cf2656bc8 100644 > --- a/drivers/mtd/nand/s3c2410.c > +++ b/drivers/mtd/nand/s3c2410.c [...] > + > +static int s3c2410_nand_init_timings(struct s3c2410_nand_info *info, > + struct nand_chip *chip) > +{ > + struct s3c2410_platform_nand *pdata = info->platform; > + const struct nand_sdr_timings *t; > + int tacls, mode; > + > + mode = onfi_get_async_timing_mode(chip); > + if (mode == ONFI_TIMING_MODE_UNKNOWN) > + mode = chip->onfi_timing_mode_default; > + > + t = onfi_async_timing_mode_to_sdr_timings(mode); > + if (IS_ERR(t)) > + return PTR_ERR(t); We recently introduced an method to automate timing selection and configuration [1]. Can you switch to this approach (the changes are in the nand/next branch [2] and should appear in 4.9-rc1)? Thanks, Boris [1]https://www.spinics.net/lists/arm-kernel/msg532007.html [2]https://github.com/linux-nand/linux/tree/nand/next -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html