Hi, On Fri, Oct 07, 2016 at 12:06:22AM +0800, Chen-Yu Tsai wrote: > +struct sun4i_tcon_quirks { > + bool is_sun5i; /* sun5i has undocumented mux */ > + bool has_channel_1; /* a33 does not have channel 1 */ > + bool has_bypass_src; /* has separate input bypassing CEU */ > + bool has_dma_src; /* has DMA input */ > +}; > + I'd really prefer to keep the has_mux quirk name. is_sun5i doesn't really relate to what we're doing there, is redundant with the compatible, and render the other quirks name useless, since we could just have is_sun.i quirks and deal with that (which is essentially what we were doing before). Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
Attachment:
signature.asc
Description: PGP signature