On 10/07/2016 11:57 AM, Guenter Roeck wrote: > On Fri, Oct 07, 2016 at 10:36:47AM +1300, Chris Packham wrote: >> Add support for the tc654 and tc655 fan controllers from Microchip. >> >> http://ww1.microchip.com/downloads/en/DeviceDoc/20001734C.pdf >> >> Signed-off-by: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx> >> --- >> >> Hi Gunter, >> >> I realise this isn't using the new hwmon registration API. This is >> essentially a forward port from an older kernel. I can attempt a >> conversion as a follow up patch but I loose the ability to actually test >> the driver. >> > No problem. > > Can you send me a register dump for this chip ? Here you go [root@awplus /flash]# i2cdump /dev/i2c-0 0x1b Dump of device 0x1b on /dev/i2c-0 0: 76 00 0a 0a 2a 02 00 54 00 b3 31 01 ff ff ff 00 v...*..T..1..... I'll read through the rest of your comments and reply with a v2 later. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
