On Sat, 1 Oct 2016, Jonathan Cameron wrote:
some more comments
> On 30/09/16 14:19, Tomas Novotny wrote:
> > Signed-off-by: Tomas Novotny <tomas@xxxxxxxxxx>
> > ---
> > .../devicetree/bindings/iio/dac/mcp4725.txt | 28 ++++++++++++++++++++++
> > 1 file changed, 28 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/iio/dac/mcp4725.txt
> >
> > diff --git a/Documentation/devicetree/bindings/iio/dac/mcp4725.txt b/Documentation/devicetree/bindings/iio/dac/mcp4725.txt
> > new file mode 100644
> > index 0000000..69c9462
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/dac/mcp4725.txt
> > @@ -0,0 +1,28 @@
> > +Microchpip mcp4725 and mcp4726 DAC device driver
Microchip
> > +
> > +Required properties:
> > + - compatible: Must be "microchip,mcp4725" or "microchip,mcp4726"
> > + - reg: Should contain the DAC I2C address
> > + - vref-millivolt: Value of the reference voltage
> > +
> > +Optional properties:
> > + - vref-mode: Reference voltage selection. It is available only on
> Not a generic attribute, so wants to have a vendor prefix on it.
> > + mcp4726. Valid values are:
> > + - 0, 1: Vdd pin voltage (unbuffered)
> This should not be a direct mapping of the register values but rather
> a means to control the setting. Having two values mapping to the
> same thing makes no sense.
>
> Would also be odd to specify a vref and then not use it. So you could
> infer this first option.
> > + - 2: Vref pin voltage unbuffered
> > + - 3: Vref pin voltage internally buffered
> Having inferred the first option then this becomes control of whether it
> is buffered or not. So could be named appropriately to cover that.
> Might be nice to have a little note here on why you might want the
> buffer or not..
> > +
> > +Examples:
> > +
> > + mcp4725@60 {
> > + compatible = "microchip,mcp4725";
> > + reg = <0x60>;
> > + vref-millivolt = <3300>;
> > + };
> > +
> > + mcp4726@60 {
> > + compatible = "microchip,mcp4726";
> > + reg = <0x60>;
> > + vref-mode = <2>;
> > + vref-millivolt = <2500>;
> > + };
> >
>
--
Peter Meerwald-Stadler
+43-664-2444418 (mobile)
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
