On Friday 30 September 2016, Felix Fietkau wrote: > >> >> + pcie0 { > >> >> + mt76@0,0 { > >> >> + reg = <0x0000 0 0 0 0>; > > > > Maybe have an examplep of a real register address other than zero? > This is a real example referring to the first device on a PCI bus. > I copy&pasted this from a .dts file that we use in LEDE. Ok, I see. > >> >> + device_type = "pci"; > >> >> + mediatek,mtd-eeprom = <&factory 0x8000>; > >> >> + mediatek,2ghz = <0>; > > > > It's not clear what the possible values for the 2ghz property are, > > can you be more verbose in the description? How is <0> different > > from no property? > 0 means disabled, no property means unchanged (compared to EEPROM). Maybe have a boolean property instead then to say "mediatek,2ghz-disabled" ? If zero is the only possible value, there is no need to put a number in there. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html