On Fri, Sep 23, 2016 at 05:30:43PM -0500, Rob Herring wrote: > > +display-subsystem { > > + compatible = "zte,zx-display-subsystem"; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + ranges; > > + > > + vou: vou@1440000 { > > + compatible = "zte,zx296718-vou"; > > + reg = <0x1440000 0x10000>; > > + interrupts = <GIC_SPI 81 IRQ_TYPE_LEVEL_HIGH>; > > + clocks = <&topcrm VOU_ACLK>, <&topcrm VOU_PPU_WCLK>, > > + <&topcrm VOU_MAIN_WCLK>, <&topcrm VOU_AUX_WCLK>; > > + clock-names = "aclk", "ppu_wclk", > > + "main_wclk", "aux_wclk"; > > + }; > > + > > + hdmi: hdmi@144c000 { > > + compatible = "zte,zx296718-hdmi"; > > + reg = <0x144c000 0x4000>; > > You have overlapping regions here. I'd suggest you kill off > zte,zx-display-subsystem and make zte,zx296718-vou the top-level node > with hdmi and others as the child nodes. I was trying to make device tree simple by defining those discrete regions in kernel driver. But honestly, I'm also unhappy about that virtual top-level node. Version 2 Will come soon with suggested bindings. Shawn -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html