On 2016-09-23 19:39, Rob Herring wrote: > On Sat, Sep 17, 2016 at 11:34:22AM +0200, Peter Rosin wrote: >> From: Gustaf Lindström <gl@xxxxxxxxxx> >> >> The Sharp 15" LQ150X1LG11 panel is an XGA TFT LCD panel. >> >> Signed-off-by: Gustaf Lindström <gl@xxxxxxxxxx> >> Signed-off-by: Peter Rosin <peda@xxxxxxxxxx> >> --- >> .../bindings/display/panel/sharp,lq150x1lg11.txt | 7 ++++++ >> drivers/gpu/drm/panel/panel-simple.c | 27 ++++++++++++++++++++++ >> 2 files changed, 34 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg11.txt >> >> v1->v2: correct author >> >> diff --git a/Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg11.txt b/Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg11.txt >> new file mode 100644 >> index 000000000000..014428c984c8 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg11.txt >> @@ -0,0 +1,7 @@ >> +Sharp 15" LQ150X1LG11 XGA TFT LCD panel >> + >> +Required properties: >> +- compatible: should be "sharp,lq150x1lg11" > > Looking at the spec, what about 12V VDD, 3.3V VCC, XSTABY (backlight > ctrl), VBR (PWM), RL/UD, SELLVDS signals? I guess you're saying that simple-panel isn't the best match? Is it ok to make the DT bindings more complete but still leave it to the simple-panel driver to support part of it? Or should we just give up for the time being, and carry a local patch pending a custom driver? Cheers, Peter -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html