On 20/09/16 19:14, Paul Kocialkowski wrote: > * PGP Signed by an unknown key > > Le mardi 20 septembre 2016 à 18:15 +0100, Jon Hunter a écrit : >> On 28/08/16 18:32, Paul Kocialkowski wrote: >>> >>> This switches a few interrupt definitions that were using >>> GPIO_ACTIVE_HIGH as IRQ type, which is invalid. >> >> May be you are right, but this does not describe why this is invalid. >> Can you elaborate? > > GPIO_ACTIVE_HIGH is simply not the right kind of define to use in the > "interrupts" devicetree property. Values provided there are understood as > IRQ_TYPE_ defines. Right, but you are changing the type as GPIO_ACTIVE_HIGH = 0 and IRQ_TYPE_EDGE_FALLING = 2 and there is no comment about why this has been changed. It might be correct, but you need to explain it. Jon -- nvpublic -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
