Re: [PATCH 11/11] ARM: DT: STM32: add dma for usart1 on F429

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> Signed-off-by: Gerald Baeza <gerald.baeza@xxxxxx>
> Signed-off-by: Alexandre TORGUE <alexandre.torgue@xxxxxx>

I just tested your patch with success in two scenarios:

1) STM32F469IDISCO board
2) Custom board running STM32F439NI

Tested-by: Bruno Herrera <bruherrera@xxxxxxxxx>

One last comment I have bellow:

>
> diff --git a/arch/arm/boot/dts/stm32f429.dtsi b/arch/arm/boot/dts/stm32f429.dtsi
> index 35df462..227376b 100644
> --- a/arch/arm/boot/dts/stm32f429.dtsi
> +++ b/arch/arm/boot/dts/stm32f429.dtsi
> @@ -161,6 +161,9 @@
>                         interrupts = <37>;
>                         clocks = <&rcc 0 164>;
>                         status = "disabled";
> +                       dmas = <&dma2 2 4 0x414 0x0>,
> +                              <&dma2 7 4 0x414 0x0>;

According to stm32-dma.txt documentation in the third parameter (32bit
mask) only the following bits can be set : 9,10,15,16,17 and 0x414 is
setting bits 2 and 4. It make sense if you look in the register itself
(DMA_SxCR) but as far I could see from the DMA driver code this bits
are set internally. The correct value should be 0x400.

> +                       dma-names = "rx", "tx";
>                 };
>
>                 usart6: serial@40011400 {
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux