On 15/09/16 14:36, Rob Herring wrote: > On Wed, Sep 14, 2016 at 04:01:24PM +0100, Robin Murphy wrote: >> Whilst we're some of the way towards a universal firmware property >> interface, drivers which deal with both OF and ACPI probing end up >> having to do things like this: >> >> dev->of_node ? &dev->of_node->fwnode : dev->fwnode >> >> This seems unnecessary, when the OF code could instead simply fill in >> the device's fwnode when binding the of_node, and let the drivers use >> dev->fwnode either way. Let's give it a go and see what falls out. >> >> Signed-off-by: Robin Murphy <robin.murphy@xxxxxxx> >> --- >> drivers/of/platform.c | 2 ++ >> 1 file changed, 2 insertions(+) > > I've applied this, but what about non-platform devices such as i2c? I was indeed wondering that, coming from the perspective of DMA/IOMMU configuration which doesn't really apply beyond the PCI and platform buses. More generally, at this point it's largely for the benefit of subsystems which need to chuck around firmware data for other devices that don't exist yet (or at all), which maybe is just the DMA and IRQ layers. I guess beyond that it comes down to auditing the intersection between callers of the property API and OF-probed buses, then killing the dev_fwnode() helper in property.c and making sure nothing else breaks. The possible alternative would be pushing this right down into device_initialize(), but that seems a bit wrong. Thanks, Robin. > > Rob > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
