Hi Chris,
On Thu, Sep 15, 2016 at 9:34 PM, Chris Brandt <chris.brandt@xxxxxxxxxxx> wrote:
> Signed-off-by: Chris Brandt <chris.brandt@xxxxxxxxxxx>
> ---
> arch/arm/boot/dts/r7s72100.dtsi | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm/boot/dts/r7s72100.dtsi b/arch/arm/boot/dts/r7s72100.dtsi
> index e18d4e6..4054db3 100644
> --- a/arch/arm/boot/dts/r7s72100.dtsi
> +++ b/arch/arm/boot/dts/r7s72100.dtsi
> @@ -450,4 +450,15 @@
> #size-cells = <0>;
> status = "disabled";
> };
> +
> + mmcif: mmc@e804c800 {
> + compatible = "renesas,mmcif-r7s72100", "renesas,sh-mmcif";
> + reg = <0xe804c800 0x80>;
> + interrupts = <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH
> + GIC_SPI 269 IRQ_TYPE_LEVEL_HIGH>;
The bindings do not say anything about interrupts (hence that should be
added).
The driver handles either 1 combined or 2 separate interrupts.
The datasheet says MMC has 3 interrupt requests, though?
> + clocks = <&mstp8_clks R7S72100_CLK_MMCIF>;
> + reg-io-width = <4>;
> + bus-width = <8>;
> + status = "disabled";
> + };
> };
The rest looks OK to me.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
