On Thu, Sep 08, 2016 at 08:23:17AM +0200, Maxime Ripard wrote:
On Wed, Sep 07, 2016 at 09:58:57AM +0200, jorik@xxxxxxxxxxxxxx wrote:From: Jorik Jonker <jorik@xxxxxxxxxxxxxx> Users using this UART without RTS/CTS should override the association in their board specific DTS. All (1) board using this UART uses RTS/CTS, so this breaks nothing.Using RTS / CTS is very rare among the boards. Forcing it down the throat of every user doesn't seem like the right thing to do.
So, I'm going for a v5, with these changes: - rename uart0_pins to uart0_pa_pins (as there could be a pf) - associate uart0_pa_pins with uart0 on all H3 board DTS files - put rts/cts in seperate pinmux sets for uart1 (2,3: see below) - associate rx/tx for uart1-3 in H3 DTSI (this is the only option) - associate UART1 rts/cts as pinctrl-1 in sun8i-h3-bananapi-m2-plus (to prevent breakage for existing users)I am a bit in doubt if I should include pinmux definitions for the following things, as Chen-Yu said to only include stuff that is actually used in a board:
- uart0_pf_pins, since there is no board using it
- uart{2,3}_rts_cts, as I agree RTS/CTS is a bit exotic
Maxime/Chen-Yu: what do you think of this?
Best,
Jorik
Attachment:
signature.asc
Description: PGP signature
