Re: [PATCH 1/2 v5] bus: qcom: add EBI2 device tree bindings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Mon, Sep 5, 2016 at 3:09 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> On Monday, September 5, 2016 2:29:24 PM CEST Linus Walleij wrote:
>> +Chip Select                     Physical address base
>> +CS0 GPIO134                     0x1a800000-0x1b000000 (8MB)
>> +CS1 GPIO39 (A) / GPIO123 (B)    0x1b000000-0x1b800000 (8MB)
>> +CS2 GPIO40 (A) / GPIO124 (B)    0x1b800000-0x1c000000 (8MB)
>> +CS3 GPIO133                     0x1d000000-0x25000000 (128 MB)
>> +CS4 GPIO132                     0x1c800000-0x1d000000 (8MB)
>> +CS5 GPIO131                     0x1c000000-0x1c800000 (8MB)
>> +
>
>
>> +- ranges: should be set to:
>> +  ranges = <0 0x0 0x1a800000 0x00800000>,
>> +           <1 0x0 0x1b000000 0x00800000>,
>> +           <2 0x0 0x1b800000 0x00800000>,
>> +           <3 0x0 0x1d000000 0x00800000>,
>> +           <4 0x0 0x1c800000 0x00800000>,
>> +           <5 0x0 0x1c000000 0x00800000>;
>>
>
> The two lists don't seem to match here: why is the CS3 area only
> listed with an 8MB mapping here when the documentation says it's
> 128 MB?

Just my bad because I'm not using it, good catch!

Resending.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux