These are cleanups against 2098142ae87d, the current pci/host-rockchip head in my tree. Changes from v1: - Rework HIWORD_UPDATE - Remove duplicate CSR definitions - Move CSR block offset from read/write caller to CSR definition - Organize CSRs into logical blocks - Fix some inconsistent CSR names - Add names for registers at the base of CSR blocks I was disappointed to find how disorganized the v10 CSR definitions were. It was quite a hodgepodge. I should have noticed that earlier, but as penance, I tried to clean it up myself. These are in git as pci/host-rockchip-wip. Again, I intend to squash these all into the single commit that adds the driver when I finally merge it. --- Bjorn Helgaas (15): Remove unused symbols, unnecessary parens, other minor comments from Rename pcie_read() and pcie_write() to rockchip_pcie_read() and Always use "rockchip" as the pointer to per-device struct. Rename struct rockchip_pcie_port to struct rockchip_pcie. Use a local "dev" to avoid repetition of "rockchip->dev". Add comment about why 32-bit read/modify/write isn't safe. Simplify the confusing HIWORD_UPDATE scheme. Remove duplicate CSR definition. Move CSR bases into definition. Group related CSR definitions together. Rename PCIE_CORE_RC_CONF_SCC_SHIFT to match similar definitions. Rename ROCKCHIP_PCIE_RPIFR1_INTR_MASK and ROCKCHIP_PCIE_RPIFR1_INTR_SHIFT The register at PCIE_CLIENT_BASE presumably has a name of its own. Add a Simplify testing of link status and speed testing. Move msleeps to address Guenter's comments. drivers/pci/host/pcie-rockchip.c | 842 ++++++++++++++++++-------------------- 1 file changed, 391 insertions(+), 451 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html