Re: [PATCH v3 06/12] arm64: dts: h3ulcb: enable SDHI0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi Geert,

On 01.09.2016 11:11, Geert Uytterhoeven wrote:
Hi Vladimir,

On Wed, Aug 31, 2016 at 12:03 PM, Vladimir Barinov
<vladimir.barinov@xxxxxxxxxxxxxxxxxx> wrote:
This supports SDHI0 on H3ULCB board SD card slot

Signed-off-by: Vladimir Barinov <vladimir.barinov@xxxxxxxxxxxxxxxxxx>
Thanks for your patch!

--- a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
@@ -82,6 +118,18 @@
         status = "okay";
  };

+&sdhi0 {
+       pinctrl-0 = <&sdhi0_pins_3v3>;
+       pinctrl-1 = <&sdhi0_pins_1v8>;
+       pinctrl-names = "default", "state_uhs";
+
+       vmmc-supply = <&vcc_sdhi0>;
+       vqmmc-supply = <&vccq_sdhi0>;
+       cd-gpios = <&gpio3 12 GPIO_ACTIVE_LOW>;
+       bus-width = <4>;
+       status = "okay";
+};
According to the schematics, SD0_WP is wired, so I think you want to add
No, it is not wired (I look on rev0.40 and rev0.46).
The microSD card connector CN6 does not have WP on H3ULCB board.

     wp-gpios = <&gpio3 13 GPIO_ACTIVE_HIGH>;
The GPIO GP_3_13 just pulled up to 3.3V power rail.

As you add UHS pins, I think you want to add

     sd-uhs-sdr50

too.
Thank you for pointing to this.
Yes.
I will respin this patch with this added.

Regards,
Vladimir

Gr{oetje,eeting}s,

                         Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                 -- Linus Torvalds


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux