On 09/01/2016 12:29 PM, Javier Martinez Canillas wrote:
> Hello Krzysztof,
>
> On 09/01/2016 11:21 AM, Krzysztof Kozlowski wrote:
>> Update examples in Samsung pinctrl dt-bindings with new macros coming
>> from header file.
>>
>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
>> ---
>> .../bindings/pinctrl/samsung-pinctrl.txt | 42 +++++++++++-----------
>> 1 file changed, 21 insertions(+), 21 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt
>> index 6db16b90873a..828ef7fdd437 100644
>> --- a/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt
>> +++ b/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt
>> @@ -238,53 +238,53 @@ Example 1: A pin-controller node with pin groups.
>>
>> uart0_data: uart0-data {
>> samsung,pins = "gpa0-0", "gpa0-1";
>> - samsung,pin-function = <2>;
>> - samsung,pin-pud = <0>;
>> - samsung,pin-drv = <0>;
>> + samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
>> + samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
>> + samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>> };
>
> I wonder if besides updating the examples, the DT binding shouldn't also
> mention include/dt-bindings/pinctrl/samsung.h and list the macros for each
> possible pin configuration.
Yes, of course it should. I actually added it at beginning but then
checkout and I tested my sed scripts... I'll fix it in v2.
Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
