On 31/08/16 16:14, Jyri Sarha wrote: > Add "blue-and-red-wiring"-device tree property and update devicetree > binding document. The red and blue components are reversed between 24 > and 16 bit modes on am335x LCDC output pins. To get 24 RGB format the > red and blue wires has to be crossed and this in turn causes 16 colors > output to be in BGR format. With straight wiring the 16 color is RGB > and 24 bit is BGR. The new property describes whether the red and blue > wires are crossed or not. If the property is not present or its value > is not recognized the legacy mode is assumed. The legacy configuration > supports RGB565, RGB888 and XRGB8888 formats. However, depending on > wiring, the red and blue colors are swapped in either 16 or 24-bit > color modes. > > For more details see section 3.1.1 in AM335x Silicon Errata: > http://www.ti.com/general/docs/lit/getliterature.tsp?baseLiteratureNumber=sprz360 > > Signed-off-by: Jyri Sarha <jsarha@xxxxxx> > --- > .../devicetree/bindings/display/tilcdc/tilcdc.txt | 22 ++++++++++++ > drivers/gpu/drm/tilcdc/tilcdc_drv.c | 42 ++++++++++++++++++++++ > drivers/gpu/drm/tilcdc/tilcdc_drv.h | 4 +++ > drivers/gpu/drm/tilcdc/tilcdc_plane.c | 9 ++--- > 4 files changed, 71 insertions(+), 6 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/tilcdc/tilcdc.txt b/Documentation/devicetree/bindings/display/tilcdc/tilcdc.txt > index 6efa4c5..5b7b5f8 100644 > --- a/Documentation/devicetree/bindings/display/tilcdc/tilcdc.txt > +++ b/Documentation/devicetree/bindings/display/tilcdc/tilcdc.txt > @@ -17,6 +17,18 @@ Optional properties: > the lcd controller. > - max-pixelclock: The maximum pixel clock that can be supported > by the lcd controller in KHz. > + - blue-and-red-wiring: Recognized values "default", "straight" or > + "crossed". This property deals with the LCDC revision 2 (found on > + AM335x) color errata [1]. > + - "default" and "straight" indicates normal wiring that supports I didn't mean to add two values for this =). Just use one, there's no benefit in supporting multiple values meaning the same thing. Tomi
Attachment:
signature.asc
Description: OpenPGP digital signature
