Hello Krzysztof, On 08/31/2016 02:13 PM, Krzysztof Kozlowski wrote: > Hi, > > Example: > - samsung,pin-function = <0x2>; > - samsung,pin-pud = <0>; > - samsung,pin-drv = <0>; > + samsung,pin-function = <PIN_FUNC_SPC_2>; > + samsung,pin-pud = <PIN_PULL_NONE>; > + samsung,pin-drv = <PIN_DRV_LV1>; > > This should be just more readable. Especially for drive strenghts which > are unobvious and different between some SoCs. > I agree that's better to have macros for these instead of using magic numbers. For all the series: Reviewed-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx> > Tested with dtx_diff: > for i in dts-old/exynos*dtb; do scripts/dtc/dtx_diff $i dts-new/$(basename $i); done > I've also tested the patches on an Exynos5800 Peach Pi board, and as expected everything is working correctly since the compiled DTB is exactly the same. So for patches 1/9 and 9/9: Tested-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx> Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
