Re: [PATCH 1/4 v2] soc: qcom: add EBI2 device tree bindings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Mon, Aug 29, 2016 at 3:16 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> On Wednesday 24 August 2016, Linus Walleij wrote:
>> +
>> +ebi2@1a100000 {
>> +     compatible = "qcom,apq8060-ebi2";
>> +     #address-cells = <2>;
>> +     #size-cells = <1>;
>> +     ranges = <0 0x0 0x1a800000 0x00800000>,
>> +              <1 0x0 0x1b000000 0x00800000>,
>> +              <2 0x0 0x1b800000 0x00800000>,
>> +              <3 0x0 0x1d000000 0x00800000>,
>> +              <4 0x0 0x1c800000 0x00800000>,
>> +              <5 0x0 0x1c000000 0x00800000>;
>> +     reg = <0x1a100000 0x1000>, <0x1a110000 0x1000>;
>> +     reg-names = "ebi2", "xmem";
>
> ...
>
>> +     foo-ebi2@1b800000 {
>> +             compatible = "foo";
>> +             reg = <2 0x1b800000 0x100>;
>> +             (...)
>> +     };
>> +};
>
> In this example, the addresses don't match: I assume the child
> node should be listed as
>
>         foo-ebi@2,0 {
>                 reg = <2 0 0x100>;
>         };
>
> instead.

Yeah it's a plain mistake, sorry..

Noticed it too when following up in the other thread.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux