Re: [PATCH] [v9] net: emac: emac gigabit ethernet controller driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On August 27, 2016 5:26:39 AM PDT, Timur Tabi <timur@xxxxxxxxxxxxxx> wrote:
>David Miller wrote:
>> From: Timur Tabi <timur@xxxxxxxxxxxxxx>
>> Date: Thu, 25 Aug 2016 16:39:03 -0500
>>
>>> +static const u8 duuid[] = {
>>> +	0x77, 0x79, 0x60, 0xbf,
>>> +	0x2d, 0xab,
>>> +	0x9d, 0x4b,
>>> +	0x94, 0xf0,
>>> +	0xe1, 0x11, 0x98, 0x01, 0xa2, 0xba
>>> +};
>>
>> This seems to be completely unused, please remove it.
>
>Sorry, I missed that during my cleanup.  I'll remove it in v10.
>
>I wonder why my compiler didn't complain about the unused static.

AFAICT this really depends on how modern your compiler is and which warnings it may now enable by default.

Since you are very close from an accepted driver, you may want to squash potential warnings (and more) with doing a sparse build (make C=) which covers a bit more than what a traditional C compiler does.

Almost there!

-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux