On Thu, Nov 28, 2013 at 5:37 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> On Thursday 28 November 2013, Jonas Jensen wrote:
>> +static void __iomem *moxart_gpio_base;
>
> Just one comment: the usual way to do such a driver is to have
> a derived data structure like
>
> struct moxart_gpio_chip {
> struct gpio_chip chip;
> void __iomem *moxart_gpio_base;
> };
>
> and dynamically allocate that from probe(), using container_of() to
> get from the gpio_chip pointer to your own structure.
I see we make this comment a lot.
On my TODO there is an item to create
Documentation/driver-model/design-patterns.txt
And document things like this. And other fun stuff like
container_of().
What do you think about this idea?
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
