On Sun, Aug 21, 2016 at 11:20 AM, Lokesh Vutla <lokeshvutla@xxxxxx> wrote:
[...]
>> +
>> +static int ti_sci_remove(struct platform_device *pdev)
>> +{
>> + struct ti_sci_info *info;
>> + int ret = 0;
>> +
>> + info = platform_get_drvdata(pdev);
>> +
>> + mutex_lock(&ti_sci_list_mutex);
>> + if (info->users)
>> + ret = -EBUSY;
>> + else
>> + list_del(&info->node);
>> + mutex_unlock(&ti_sci_list_mutex);
>
> shouldn't the mbox channels be freed in remove?
>
> mbox_free_channel(info->chan_tx);
> mbox_free_channel(info->chan_rx);
Uggh.. yes.. my bad. thanks for catching this. will fix with a v2 next
week if there are no further comments.
--
Regards,
NIshanth Menon
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
