> Signed-off-by: Kedareswara rao Appana <appanad@xxxxxxxxxx> > --- > Thanks a lot Andrew for your inputs. > Changes for v5: > --> Fixed return values in the probe as suggested by punnaiah. > --> Added a mask for the converter speed as suggested by punnaiah. > +/* Xilinx GMII2RGMII Converter driver > + * > + * Copyright (C) 2016 Xilinx, Inc. > + * > + * Author: Kedareswara rao Appana <appanad@xxxxxxxxxx> Not cool https://github.com/lunn/linux/commit/03d375489ceb56e171056f44d0fe9c34ca5a098e Notice the Not-Signed-off-by: Andrew Lunn <andrew@xxxxxxx> and the Copyright i added? In various emails i gave you the basic idea how this should be done, a framework of code, and then took your code which did not even compile and made the core of it work. This is as much my code as your code, so i expect my Copyright to be kept on this code. And since this is my code, i need to give a Signed-off-by, which i was not yet ready to give since the code was not complete or working. Please put both my Copyright back and Not-Signed-Off-by back and post the next version as RFC. Once i'm happy this code is O.K, i will give you a Signed-off-by. Andrew -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html