Hi All, On 10/08/2016 05:58, John Stultz wrote: > On Tue, Aug 9, 2016 at 9:34 PM, Bjorn Andersson > <bjorn.andersson@xxxxxxxxxx> wrote: >> On Mon 08 Aug 16:03 PDT 2016, John Stultz wrote: >> >> [..] >>> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts >> [..] >>> memory@0 { >>> device_type = "memory"; >>> reg = <0x00000000 0x00000000 0x00000000 0x05e00000>, >>> - <0x00000000 0x05f00000 0x00000000 0x00eff000>, >>> + <0x00000000 0x05f00000 0x00000000 0x00001000>, >>> + <0x00000000 0x05f02000 0x00000000 0x00efd000>, >>> <0x00000000 0x06e00000 0x00000000 0x0060f000>, >>> <0x00000000 0x07410000 0x00000000 0x36bf0000>; >>> }; >> >> As I said when talked about this, I don't think you should punch holes >> in the /memory node, but rather add these regions as no-map in a >> /reserved-memory node. But that's a unrelated matter. > > Yea. I need to sync w/ Wei and Guodong to see about reworking all of > those to use /reserved-memory, but for now I'd like to stay in sync w/ > how they have it setup. > Both are fine to me. I remember before we had a discussion [1]. How about we add these functions this time and clean the memory node in the future if needed? [1] http://patches.linaro.org/patch/54682/ Best Regards, Wei >>> >>> + reboot-mode-syscon@5f01000 { >>> + compatible = "syscon", "simple-mfd"; >>> + reg = <0x0 0x05f01000 0x0 0x00001000>; >>> + >>> + reboot-mode@0 { >> >> Drop the @0 > > Will do. > > >> >> Other than that: >> Acked-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> > > Thanks! > -john > > . > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html