On Thu, Aug 11, 2016 at 2:45 AM, Mark Brown <broonie@xxxxxxxxxx> wrote: > On Wed, Aug 10, 2016 at 05:44:55PM -0700, Tim Harvey wrote: >> On Wed, Aug 10, 2016 at 4:41 AM, Mark Brown <broonie@xxxxxxxxxx> wrote: > >> >> +/* LDO1 always on fixed 0.8V-3.3V via scalar via R1/R2 feeback res */ >> >> +static struct regulator_ops ltc3676_fixed_standby_regulator_ops = { >> >> +}; > >> > Remove this, it's pointless. > >> as I'm using macro's to define the ops, removing this ends up breaking >> compilation: > >> do you know of some macro foo to best handle this? Part of me wants to >> ditch the macro's and just simply declare the array of regulators >> directly as its much easier to read/follow. > > Just don't use the macro for that regulator? > Mark, regulators must have a non-null ops field or they will fail registration so I can't just not assign it. What would be an appropriate ops structure for a always-on fixed regulator? Regards, Tim -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html