On Thu, Nov 28, 2013 at 06:40:57AM +0000, Simon Horman wrote:
> Update the compat strings to provide hardware-specific compat strings
> for each variant of the hardware that is supported.
>
> Also provide an example which was previously missing from
> the bindings documentation
>
> Cc: devicetree@xxxxxxxxxxxxxxx
> Signed-off-by: Simon Horman <horms+renesas@xxxxxxxxxxxx>
> ---
> .../interrupt-controller/renesas,intc-irqpin.txt | 29 +++++++++++++++++++++-
> 1 file changed, 28 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/renesas,intc-irqpin.txt b/Documentation/devicetree/bindings/interrupt-controller/renesas,intc-irqpin.txt
> index 1f8b0c5..240ab2a 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/renesas,intc-irqpin.txt
> +++ b/Documentation/devicetree/bindings/interrupt-controller/renesas,intc-irqpin.txt
> @@ -2,7 +2,12 @@ DT bindings for the R-/SH-Mobile irqpin controller
>
> Required properties:
>
> -- compatible: has to be "renesas,intc-irqpin"
> +- compatible: Must be one of the following:
s/be/contain/
> + "renesas,intc-irqpin"
> + "renesas,intc-irqpin-r8a7740"
> + "renesas,intc-irqpin-r8a7778"
> + "renesas,intc-irqpin-r8a7779"
> + "renesas,intc-irqpin-sh73a0"
> - #interrupt-cells: has to be <2>: an interrupt index and flags, as defined in
> interrupts.txt in this directory
I looked in this file in mainline, and the binding does not describe
that the reg entries are _required_ as the driver implies:
---->8----
/* get hold of manadatory IOMEM */
for (k = 0; k < INTC_IRQPIN_REG_NR; k++) {
io[k] = platform_get_resource(pdev, IORESOURCE_MEM, k);
if (!io[k]) {
dev_err(&pdev->dev, "not enough IOMEM resources\n");
ret = -EINVAL;
goto err0;
}
}
---->8----
Please add a description of the reg entries to the required properties
section of the binding, along with a description of what they correspond
to.
>
> @@ -14,3 +19,25 @@ Optional properties:
> if different from the default 4 bits
> - control-parent: disable and enable interrupts on the parent interrupt
> controller, needed for some broken implementations
Similarly, please describe the interrupts, and what they are logically.
> +
> +Example:
> +
> + irqpin0: irqpin@e6900000 {
> + compatible = "renesas,intc-irqpin";
> + #interrupt-cells = <2>;
> + interrupt-controller;
Please mention this as required too.
> + reg = <0xe6900000 4>,
> + <0xe6900010 4>,
> + <0xe6900020 1>,
> + <0xe6900040 1>,
> + <0xe6900060 1>;
> + interrupt-parent = <&gic>;
> + interrupts = <0 149 IRQ_TYPE_LEVEL_HIGH
> + 0 149 IRQ_TYPE_LEVEL_HIGH
> + 0 149 IRQ_TYPE_LEVEL_HIGH
> + 0 149 IRQ_TYPE_LEVEL_HIGH
> + 0 149 IRQ_TYPE_LEVEL_HIGH
> + 0 149 IRQ_TYPE_LEVEL_HIGH
> + 0 149 IRQ_TYPE_LEVEL_HIGH
> + 0 149 IRQ_TYPE_LEVEL_HIGH>;
Please bracket these individually.
Otherwise, this looks fine to me.
Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
