Re: [PATCH 12/17] spi/qspi: convert driver to enable/disable memory mapped.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi Mark,
On Tuesday 26 November 2013 06:41 PM, Mark Brown wrote:
On Tue, Nov 26, 2013 at 01:05:08PM +0530, Sourav Poddar wrote:
Idea is to enable memory mapped by default at the end of the probe,
if the control reaches the "transfer" api, then the operation is
not a memory mapped one. Hence, we switch to Normal mode and at the
end of the "transfer" function. switch back to memory mapped mode.
This doesn't see safe, what happens if something tries to use the map
while a transfer is in progress?
Transfer gets initiated with the following api "ti_qspi_start_transfer_one".

At the beginning of this api, I am doing a "disable memory mapped", as becuase of the code implemntation, if the control has reaches this api, memory mapped is not
the desired operation. Then, at the end of this api after
"spi_finalize_current_message(master)", which indicated the current transfer complete, I issue a end of transfer command. Only after which, I enable memory mapped mode again.

So, will the condition you mention above will hit.? Please help me understand if i am
missing something?

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux