Re: [PATCHv2] watchdog: xilinx: Add clock support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Thu, Aug 4, 2016 at 10:59 PM, Rob Herring <robh@xxxxxxxxxx> wrote:
> On Wed, Aug 03, 2016 at 09:58:38AM +0530, Shubhrajyoti Datta wrote:
>> Add support for the clock. Currently we enable
>> at probe and relinquish at remove.
>>
>> Acked-by: Sören Brinkmann <soren.brinkmann@xxxxxxxxxx>
>> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xxxxxxxxxx>
>> ---
>> v2:
>> fix spaces and error path.
>>
>>  .../devicetree/bindings/watchdog/of-xilinx-wdt.txt |  3 +++
>>  drivers/watchdog/of_xilinx_wdt.c                   | 23 ++++++++++++++++++++--
>>  2 files changed, 24 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/watchdog/of-xilinx-wdt.txt b/Documentation/devicetree/bindings/watchdog/of-xilinx-wdt.txt
>> index 6d63782..b0a9fa3 100644
>> --- a/Documentation/devicetree/bindings/watchdog/of-xilinx-wdt.txt
>> +++ b/Documentation/devicetree/bindings/watchdog/of-xilinx-wdt.txt
>> @@ -5,6 +5,8 @@ Required properties:
>>  - compatible         : Should be "xlnx,xps-timebase-wdt-1.00.a" or
>>                         "xlnx,xps-timebase-wdt-1.01.a".
>>  - reg                        : Physical base address and size
>> +- clocks             : Input clock specifier. Refer to common clock
>> +                       bindings.
>
> You can't add new required properties. Doing so breaks compatibility
> with old DTs.
Will resend fixing the compatibility with old dts.

>
> Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux