Re: [PATCH] ARM: dts: da850: Add basic DTS for the L138/C6748 Dev Kit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Karl Beldan <kbeldan@xxxxxxxxxxxx> writes:

> On Thu, Aug 04, 2016 at 12:15:05PM -0700, Kevin Hilman wrote:
>> + Sekhar
>> 
>> Hi Karl,
>> 
>> Karl Beldan <kbeldan@xxxxxxxxxxxx> writes:
>> 
>> > The LCDK is the successor to the late Hawkboard and has the same machine
>> > number.
>> 
>> Machine number is only relevant for legacy (non-DT) boot and this is DT
>> boot, so the machine number bit really relevant for this changelog.
>> 
> Hi Kevin,
>
> It was purely informative.
>
>> BTW, have you tried legacy boot on LCDK with board-omapl138-hawk.c?  I
>> assume it mostly works?
>>
> Yes.
>
>> > Among the differences are the flash (16bits vs 8bits) and some pins
>> > (MMC, LEDs, buttons, some external connectors), however the main
>> > components remain the same (eth. PHY, Audio Codec, Video decoder and
>> > DAC) except for the main PMIC, different and hard-wired on the LCDK (the
>> > LDOs and DCDCs are always ON).
>> > A DT-only boot with this addition gives functional uart, reboot via
>> > watchdog, rtc, ethernet and MMC (I added the CD gpio for the MMC
>> > although davinci_mmc doesn't call yet the mmc core OF facilities).
>> >
>> > Signed-off-by: Karl Beldan <kbeldan@xxxxxxxxxxxx>
>> 
>> Tested with v4.7 on my LCDK board.
>> 
>> Tested-by: Kevin Hilman <khilman@xxxxxxxxxxxx>
>> 
>> Note that I also needed CONFIG_RTC_DRV_OMAP=m enabled in
>> davinci_all_defconfig for the RTC driver. Could you add a patch for that
>> to this series as well?
>> 
> No problem. BTW do you also consider CONFIG_ items not arch specific
> (like CONFIG_NET_VENDOR_SMSC) ?

Do you mean for davinci_all_config?  Yes.

>
>> Also, plese Cc the co-maintainer Sekhar Nori (now Cc'd) on all future
>> davinci patches.
>> 
> Sure.
>
>> > ---
>> >  Documentation/devicetree/bindings/arm/davinci.txt |  4 ++
>> >  arch/arm/boot/dts/Makefile                        |  1 +
>> >  arch/arm/boot/dts/omapl138-lcdk.dts               | 71 +++++++++++++++++++++++
>> 
>> I think this should be called da850-lcdk.dts.
>> 
>> The OMAP prefix in the DT directory is just going to cause confusion,
>> and the other DTs using this same SoC are already called da850.
>> 
> That's what I thought too, mainline U-Boot is using omapl138_lcdk but
> yes da850 is less confusing given the code already present (downside is
> when you search for da850 on the net there's nothing).

OK, let's stick with da850 for the DT names.  The other help texts
already list all the names da850/omapl138/am18x so we should be fine.

Kevin
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux