Hi Guenter, On 3.8.2016 18:23, Guenter Roeck wrote: > On 08/02/2016 09:28 PM, Shubhrajyoti Datta wrote: >> Add support for the clock. Currently we enable >> at probe and relinquish at remove. >> >> Acked-by: Sören Brinkmann <soren.brinkmann@xxxxxxxxxx> >> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xxxxxxxxxx> > > Patch itself looks good. > > Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx> > > Do you have a separate patch to add the clock to virtex440-ml507.dts ? > > Not that it matters much, I guess - virtex440-ml507.dts says > compatible = "xlnx,xps-timebase-wdt-1.00.b"; > which isn't supported by of_xilinx_wdt.c, and not documented in > of-xilinx-wdt.txt. Is that an oversight or on purpose ? We had an internal discussion about ppc405 and ppc440 support and truth is Xilinx is not doing any testing on these cpus and the part of that is that none is keeping stuff up2date. I tried to remove xilinx ppc support from U-Boot because I didn't see activity there but there were people who invested their time to do necessary changes to keep it alive. I think kernel is just a same case. I am happy to remove these xilinx ppc4xx dtses from the kernel but I expect that there will be others who want to have it there. And this is the group who should keep these dtses up2date and test them regularly. Thanks, Michal -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
