On Sun, Jul 31, 2016 at 8:23 PM, Wu, Songjun <Songjun.Wu@xxxxxxxxxxxxx> wrote: > > > On 7/30/2016 05:44, Rob Herring wrote: >> >> On Fri, Jul 29, 2016 at 03:54:08PM +0800, Songjun Wu wrote: >>> >>> DT binding documentation for ISC driver. >>> >>> Signed-off-by: Songjun Wu <songjun.wu@xxxxxxxxxxxxx> >>> --- >>> >>> Changes in v7: None >>> Changes in v6: >>> - Add "iscck" and "gck" to clock-names. >>> >>> Changes in v5: >>> - Add clock-output-names. >>> >>> Changes in v4: >>> - Remove the isc clock nodes. >>> >>> Changes in v3: >>> - Remove the 'atmel,sensor-preferred'. >>> - Modify the isc clock node according to the Rob's remarks. >>> >>> Changes in v2: >>> - Remove the unit address of the endpoint. >>> - Add the unit address to the clock node. >>> - Avoid using underscores in node names. >>> - Drop the "0x" in the unit address of the i2c node. >>> - Modify the description of 'atmel,sensor-preferred'. >>> - Add the description for the ISC internal clock. >>> >>> .../devicetree/bindings/media/atmel-isc.txt | 65 >>> ++++++++++++++++++++++ >>> 1 file changed, 65 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/media/atmel-isc.txt >> >> >> Please add acks when posting new versions. >> >> Rob >> > Hi Rob, > > Thank you for your reminder. > > Should I Add 'Acked-by: Rob Herring <robh@xxxxxxxxxx>' behind > 'Signed-off-by: Songjun Wu <songjun.wu@xxxxxxxxxxxxx>'? Before or after is fine. > Should I resend this patch? Not just to add acks, but if you send v8, add the acks. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
