Re: [PATCH 1/2 v2] hwmon: (ltc4151) Make shunt-resistor configurable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 07/30/2016 09:11 AM, Daniel Golle wrote:
Hi Guenter,

On Sat, Jul 30, 2016 at 09:00:14AM -0700, Guenter Roeck wrote:
Daniel,

On 07/25/2016 04:56 AM, Daniel Golle wrote:
Allow to specify the resistance of the attached shunt via DT by
adding the shunt-resistor property. Fall-back to the previous
default (1 mOhm) if unset.

Signed-off-by: Daniel Golle <daniel@xxxxxxxxxxxxxx>

Please resend with the property name changed as asked for by Rob.

Ok, will do. I originally copy-pasted the property name from ina209,
so I reckon it's supposed to be changed there as well...?


One can not simply change an existing property. We would have to deprecate
the old one, define a replacement, and have the driver support both. For
ina2xx, it would have to be done in the iio driver as well.

Sure, if you feel up to it, feel free to prepare a set of patches to do that.

Note that Documentation/devicetree/bindings/property-units.txt documents
that -micro-ohms should be used.

Thanks,
Guenter

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux