On Wed, Jul 27, 2016 at 4:35 PM, Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote: > On Tue, Jul 19, 2016 at 11:44:25AM -0700, Dmitry Torokhov wrote: >> On Sat, Jul 16, 2016 at 12:56:05PM -0500, Rob Herring wrote: >> > On Mon, Jul 11, 2016 at 05:51:44PM +0200, Hans de Goede wrote: >> > > From: Robert Dolca <robert.dolca@xxxxxxxxx> >> > > >> > > This driver adds support for Silead touchscreens. It has been tested >> > > with GSL1680 and GSL3680 touch panels. >> > > >> > > It supports ACPI and device tree enumeration. Screen resolution, >> > > the maximum number of fingers supported and firmware name are >> > > configurable. >> > > >> > > Signed-off-by: Robert Dolca <robert.dolca@xxxxxxxxx> >> > > Signed-off-by: Daniel Jansen <djaniboe@xxxxxxxxx> >> > > Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> >> > > --- >> > > Changes in v6: >> > > -Default to 5 fingers if max-fingers is not specified >> > > -Improve devicetree binding doc: improve wake-gpios description, use >> > > "See touchscreen.txt" where applicable >> > > --- >> > > .../bindings/input/touchscreen/silead_gsl1680.txt | 36 ++ >> > > drivers/input/touchscreen/Kconfig | 13 + >> > > drivers/input/touchscreen/Makefile | 1 + >> > > drivers/input/touchscreen/silead.c | 652 +++++++++++++++++++++ >> > > 4 files changed, 702 insertions(+) >> > > create mode 100644 Documentation/devicetree/bindings/input/touchscreen/silead_gsl1680.txt >> > > create mode 100644 drivers/input/touchscreen/silead.c >> > > >> > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/silead_gsl1680.txt b/Documentation/devicetree/bindings/input/touchscreen/silead_gsl1680.txt >> > > new file mode 100644 >> > > index 0000000..1e58d37 >> > > --- /dev/null >> > > +++ b/Documentation/devicetree/bindings/input/touchscreen/silead_gsl1680.txt >> > > @@ -0,0 +1,36 @@ >> > > +* GSL 1680 touchscreen controller >> > > + >> > > +Required properties: >> > > +- compatible : "silead,gsl1680" >> > > +- reg : I2C slave address of the chip (0x40) >> > > +- interrupt-parent : a phandle pointing to the interrupt controller >> > > + serving the interrupt for this chip >> > > +- interrupts : interrupt specification for the gsl1680 interrupt >> > > +- power-gpios : Specification for the pin connected to the gsl1680's >> > > + shutdown input. This needs to be driven high to take the >> > > + gsl1680 out of its low power state >> > > +- touchscreen-size-x : See touchscreen.txt >> > > +- touchscreen-size-y : See touchscreen.txt >> > > +- touchscreen-max-fingers : maximum number of fingers the touchscreen can detect >> > >> > If you name it like a standard property, then it should be documented in >> > touchscreen.txt. >> >> Actually this is very much Silead-specific wart, I'd rather we called it >> "max-fingers" or "silead,max-fingers" to illustrate that it is not at >> all a generic property. >> >> Rob, will you be OK with it? > > Rob, ping? I'd like to get it into the tree and this is only outstanding > question. Okay. With vendor prefix please. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
