On Wed, 27 Nov 2013, Krzysztof Kozlowski wrote: > MAX14577 chip is a multi-function device which includes MUIC, > charger and voltage regulator. The driver is located in drivers/mfd. > > This patch adds regulator driver for MAX14577 chip. There are two > regulators in this chip: > 1. Safeout LDO with constant voltage output of 4.9V. It can be only > enabled or disabled. > 2. Current regulator for the charger. It provides current from 90mA up > to 950mA. > Driver supports Device Tree. > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx> > Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx> > --- > drivers/mfd/max14577.c | 13 +- > drivers/regulator/Kconfig | 7 ++ > drivers/regulator/Makefile | 1 + > drivers/regulator/max14577.c | 269 ++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 287 insertions(+), 3 deletions(-) > create mode 100644 drivers/regulator/max14577.c > > diff --git a/drivers/mfd/max14577.c b/drivers/mfd/max14577.c > index 94b766d..9af46c2 100644 > --- a/drivers/mfd/max14577.c > +++ b/drivers/mfd/max14577.c > @@ -25,9 +25,16 @@ > #include <linux/mfd/max14577-private.h> > > static struct mfd_cell max14577_devs[] = { > - { .name = "max14577-muic", }, > - { .name = "max14577-regulator", }, > - { .name = "max14577-charger", }, > + { > + .name = "max14577-muic", > + }, > + { > + .name = "max14577-regulator", > + .of_compatible = "maxim,max14577-regulator", > + }, > + { > + .name = "max14577-charger", > + }, > }; Still it still part of the regulator patch. Can you pull the code above into a separate patch please? Also, there's no requirement to open out all of the one liners, just the entry where you're using two properties. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html