Hi, Sorry for the delay. I don't have any major comments, there are jsut a couple of minor details. > +config MESON_SM > + bool > + default ARCH_MESON > + depends on ARM64_4K_PAGES It would be good to have a commentin the code as to why we depend on ARM64_4K_PAGES. That way it's possible for others to figure out without having to go digging through mail archives and/or git logs. [...] > +struct meson_sm_chip gxbb_chip = { > + .shmem_size = 0x1000, If you include <linux/sizes.h>, you can use SZ_4K here. Immediately above this is probably the best place for the comment regarding the 4K page restriction imposed by the FW interface. Other than that this looks fine, so FWIW: Acked-by: Mark Rutland <mark.rutland@xxxxxxx> Thanks, Mark. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html