Hi Mark, On Thu, Jul 21, 2016 at 06:14:58PM +0100, Mark Rutland wrote: > On Thu, Jul 21, 2016 at 03:27:47PM +0300, Vladimir Barinov wrote: > > Add the initial device tree for the R8A7795 SoC based H3ULCB low cost > > board. > > > > This commit supports the following peripherals: > > - SCIF (console), Ethernet, SD, USB Host, Audio, GPIO LEDs > > > > Signed-off-by: Vladimir Barinov <vladimir.barinov@xxxxxxxxxxxxxxxxxx> > > --- > > arch/arm64/boot/dts/renesas/Makefile | 2 +- > > arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts | 326 +++++++++++++++++++++++++ > > 2 files changed, 327 insertions(+), 1 deletion(-) > > create mode 100644 arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts > > > > diff --git a/arch/arm64/boot/dts/renesas/Makefile b/arch/arm64/boot/dts/renesas/Makefile > > index 17139f7..eb72830 100644 > > --- a/arch/arm64/boot/dts/renesas/Makefile > > +++ b/arch/arm64/boot/dts/renesas/Makefile > > @@ -1,4 +1,4 @@ > > -dtb-$(CONFIG_ARCH_R8A7795) += r8a7795-salvator-x.dtb > > +dtb-$(CONFIG_ARCH_R8A7795) += r8a7795-salvator-x.dtb r8a7795-h3ulcb.dtb > > dtb-$(CONFIG_ARCH_R8A7796) += r8a7796-salvator-x.dtb > > > > always := $(dtb-y) > > diff --git a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts > > new file mode 100644 > > index 0000000..e4400fb > > --- /dev/null > > +++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts > > @@ -0,0 +1,326 @@ > > +/* > > + * Device Tree Source for the H3ULCB board > > + * > > + * Copyright (C) 2016 Renesas Electronics Corp. > > + * Copyright (C) 2016 Cogent Embedded, Inc. > > + * > > + * This file is licensed under the terms of the GNU General Public License > > + * version 2. This program is licensed "as is" without any warranty of any > > + * kind, whether express or implied. > > + */ > > + > > +/* > > + * SSI-AK4613 > > + * > > + * This command is required when Playback/Capture > > + * > > + * amixer set "DVC Out" 10% > > + * amixer set "DVC In" 10% > > + */ > > I don't think this comment belongs here. It has nothing to do with the > DT as such. > > Why is this necessary? Is this a bug? For historical reasons the mixer settings required to get functional sound have been documented in DT files. The above is in keeping with that. Personally I find this quite helpful but I think it would be at least as helpful documented on elinux.org or somewhere similar. So I would not object to it being omitted from here and consideration given to removing it from other Renesas DT files. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
