Re: [PATCH v2 5/6] libfdt: Add fdt_setprop_inplace_namelen_partial

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Mon, Jul 18, 2016 at 03:45:58PM +0200, Maxime Ripard wrote:
> Hi David,
> 
> On Tue, Jul 12, 2016 at 09:45:20PM +1000, David Gibson wrote:
> > On Mon, Jul 11, 2016 at 09:56:22PM +0200, Maxime Ripard wrote:
> > > Add a function to modify inplace only a portion of a property..
> > > 
> > > This is especially useful when the property is an array of values, and you
> > > want to update one of them without changing the DT size.
> > > 
> > > Signed-off-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx>
> > > Acked-by: Simon Glass <sjg@xxxxxxxxxxxx>
> > 
> > Reviewed-by: David Gibson <david@xxxxxxxxxxxxxxxxxxxxx>
> > 
> > Now it just needs some testcases..
> 
> Since fdt_setprop_inplace relies on it now, it already has some test
> coverage.
> 
> However, I tried to add some testcases for this to the test_tree1, but
> it was generating a lot of errors because it seems that not all tests
> are run from test_tree1.dts and generated by some other mean I
> couldn't identify. Could you point me to the right direction?

I'm not quite sure what you mean.

test_tree1 is generated in a number of different ways - these are
cross-compared at various points as part of the tests.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux